-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS feed from search results (Angular) #3227
Conversation
Hi @ConfusionOrb221, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ConfusionOrb221!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @ConfusionOrb221 ! I tested this as well and it seems to work well.
References
Description
Adjusts RSS to show on search pages as well as include page, discovery configuration, and search filter information.
Instructions for Reviewers
RssComponent now looks at the discovery configruation of the search page it is attached to and then provides the information to the openSearch endpoint. This has also been updated to including the following information:
To test this pr you have to use the provided rest branch and then verify that rss button on search pages has results that match search queries no matter the filters or actual query provided.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.