Removed unnecessary *ngVars from ThumbnailComponent #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto w2p-116728_removed-unnecessary-ngvars_contribute-main # Conflicts: # src/app/thumbnail/thumbnail.component.ts
alexandrevryghem
added
bug
component: Item
tdonohue
added
port to dspace-7_x
tdonohue
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Finally got around to testing/reviewing this today. It all looks good and works well.
|
Successfully created backport PR for |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3221-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3221-to-dspace-8_x
git switch --create backport-3221-to-dspace-8_x
git cherry-pick -x d31e17894ce3f8f6be82f426de879816d76acd97 |
tdonohue
removed
port to dspace-7_x
alexandrevryghem
deleted the
w2p-116728_removed-unnecessary-ngvars_contribute-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR removes the unnecessary
*ngVars in theThumbnailComponent. When you disable caching and you run dspace in prod mode you will still be able to see that the content is retrieved twice, but this can't be avoided. The first time it is triggered by the SSR and the second time by CSR. We can't change that, but we should still remove the*ngVars since they are actually not necessary and*ngVars also triggerfixture.detectChanges()every time there is interaction with the template so that's not really good for performance.Instructions for Reviewers
We actually don't need those
BehaviourSubjects because we don't subscribe to them except in the template, so I just converted them back to regular string/boolean fields. Everything should still work like they did before.Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.