Orcid Authorization / Synchronization Page Fixes #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: - Introduces reactive states derived from item inside orcid-sync page - Removes unnecessary navigation ref: - Introduces catchError operator and handles failures with error messages
11 tasks
tdonohue
added
authentication: general
11 tasks
tdonohue
added
bug
and removed
port to dspace-8_x
10 tasks
|
Hi @vins01-4science, |
kshepherd
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
+1 i have tested these changes with our sandbox ORCID integration and the error handling is fixed, all other changes look good and no problems detected. thanks @vins01-4science
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this development has been funded by the ORCID Global Participation Fund.
DSpace 7_x version here: #3182
DSpace 8.x version here: #3216
References
Description
This PR solves various issues related to the orcid synchronization feature (those issues were related to the stale status of a request saved inside the cache). The full list of issues can be found here: #8925.
Instructions for Reviewers
You should check the behavior of the synchronization page, as suggested inside the issue #8925.
Moreover, you should check that the
codeparameter of the URL is cleared once the account has been connected successfully by using the proper button (Connect to Orcid)List of changes in this PR:
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.