[Port main] Remove Bitstreams on edit-item-page doesn't work #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& removed method calls retuning observables in edit collection's content source tab
alexandrevryghem
added
bug
high priority
component: Item
8 tasks
tdonohue
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Tested this PR on top of latest main and verified this fixes the bug. The code looks good & matches with what is in #3121
alexandrevryghem
deleted the
w2p-113560_edit-item-add-relationships-one-by-one_contribute-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3116
Manual port of #3121 to
main.Also contains a fix for the bitstream routing module sometimes complaining about
Error: NG04014: Invalid configuration of route 'bitstreams/handle/:prefix/:suffix/:filename'. One of the following must be provided: component, loadComponent, redirectTo, children or loadChildren