Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong prefix added to the year of a date input type in submission #3122

Open
wants to merge 3 commits into
base: dspace-7_x
Choose a base branch
from

Conversation

VictorHugoDuranS
Copy link
Contributor

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Instructions for Reviewers

I added a function for year input to convert partial number years to full year values.

List of changes in this PR:

To review and check I attach a video with the changes added:

0614.mp4

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge component: submission port to main This PR needs to be ported to `main` branch for the next major release labels Jun 17, 2024
@tdonohue tdonohue changed the title Dspace 7 2882 Fix Wrong prefix added to the year of a date input type in submission Aug 8, 2024
@tdonohue tdonohue requested a review from atarix83 August 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission port to main This PR needs to be ported to `main` branch for the next major release
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

2 participants