Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Site hangs when selecting items via keyboard from the hamburger menu #3115

Conversation

EikLoe
Copy link
Member

@EikLoe EikLoe commented Jun 13, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

Instructions for Reviewers

Follow the steps described in the related issue using different browsers (Chrome, Firefox, Edge, Safari) and check if the error still exists.

List of changes in this PR:

  • Changed key-listener to keydown in order to work on chrome browsers.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jun 13, 2024
@tdonohue tdonohue added this to the 8.0 milestone Jun 13, 2024
@tdonohue tdonohue self-requested a review June 13, 2024 12:09
@tdonohue tdonohue added accessibility testathon Reported by a tester during Community Testathon labels Jun 13, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Leano1998 ! I gave this a try today, and it works well. I initially realized that sometimes this hamburger menu is working for me on sandbox.dspace.org and demo.dspace.org...but it also does hang at times. This change to use keydown appears to stabilize it (I no longer can reproduce the hanging behavior).

Tested in Chrome, Firefox, and Edge. All work well.

@tdonohue tdonohue merged commit 5040811 into DSpace:main Jun 14, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Jun 14, 2024
@EikLoe EikLoe deleted the fix/#2957-hamburger-menu-hangs-on-keyboard-use branch September 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug testathon Reported by a tester during Community Testathon
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Hangs when selecting items via keyboard from the hamburger menu - content does not appear (versions 7 and 8)
3 participants