Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main branch synced with dspace-7.6.1 tag (Angular version) #3114

Closed
wants to merge 257 commits into from

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Jun 12, 2024

References

Description

This PR shows the behavior of running git merge -s ours dspace-7.6.1 on the main branch.

This command will reset their common ancestor and is also the recommended way to "supersede old development history of side branches" according to Git documentation.

  • This action should be done after every minor release from the maintenance branch. It should always be merged back to "main" using the "-s ours" flag.

How to test

Pretend you are starting with a 7.6.1 release, and attempt an upgrade

  1. Checkout 7.6.1 to a branch: git checkout -b test_upgrade_from_7.6.1 dspace-7.6.1
  2. Upgrade by merging this PR's branch into 7.6.1: git merge main_synched_with_7.6.1

Alternatively, see what it looks like in git diff:

DO NOT MERGE: This PR is simply a reference example for what this merger looks like.

tdonohue and others added 30 commits July 28, 2023 20:11
[Port dspace-7_x] Add GitHub action to automatically create a port PR (based on label) & minor bug fixes
Contributed by Reeta Kuukoski from the National Library of Finland.
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 0b0c60e)
[Port dspace-7_x] Bump semver from 5.7.1 to 5.7.2
[Port dspace-7_x] refactor: rename aletr-type.ts to alert-type.ts
src/assets/i18n: update Finnish language strings
…laying-twiced-in-ui_contribute-maintenance-7.6

[Port dspace-7_x] Fixed MathJax code being displayed twice by `dsMarkdown` pipe
[Port dspace-7_x] Catch and handle unsuccessful "convert rels to items" responses
[Port dspace-7_x] Show error message from the password validation response
New strings for status filter entries:
search.filters.namedresourcetype.*
Refactored strings introduced with DSpace#2068 (refactor badged),
e.g. mydspace.status.archived -> mydspace.status.mydspaceArchived
[Port dspace-7_x] fix(i18n): add and update missing status strings
…orm-bugs_contribute-maintenance-7.6

[Port dspace-7_x] Fix minor collection form bugs
[Port dspace-7_x] ProcessDetailComponent test improvement
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 2fec33e)
[Port dspace-7_x] Bump word-wrap from 1.2.3 to 1.2.5
- Correct the path in commented-out code in the custom theme's
  components
- Clarify that the workflow-item-sen-back.component.scss file is a stub
- It has no corresponding SCSS file in the base theme

(cherry picked from commit 0906234)
[Port dspace-7_x] 2437 Correct and clarify commented-out code in several custom components
[Port dspace-7_x] Replace mentions of demo7.dspace.org and api7.dspace.org with new demo URLs
Update from 7.4 to 7.6 version

(cherry picked from commit b439ab4)
paulo-graca and others added 20 commits November 13, 2023 17:30
[Port dspace-7_x] Fix handle redirect not working with custom nameSpace
[Port dspace-7_x] adding new access-status-list-element-badge css classes
…prevent circular dependencies

(cherry picked from commit da8880e)
…fined whey calling the ngOnDestroy in the ThemedComponent

(cherry picked from commit 4e54cca)
(cherry picked from commit b6d515f)
(cherry picked from commit 6f64db1)
[Port dspace-7_x] Fix match theme by handle with canonical prefix https://hdl.handle.net/ not working
(cherry picked from commit fbbbc18)
[Port dspace-7_x] Fixes "some item edit pages are accessible by anonymous users"
[Port dspace-7_x] Edit-item view: random order of buttons in status tab
[Port dspace-7_x] Fixed menu not updating when a new sub section is added after rendering has already completed
Copy link
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdonohue!

This looks good, everything seems to work as it should.

If you compare the directories of the main branch and this PR (with the latest main merged in), they are identical, and if you look at the git history of a file that had different changes on 7.x and main, it simply looks like the 7.x changes came first and were replaced by the ones on main.

So this seems like a good way to do it

@tdonohue
Copy link
Member Author

Closing, this change was made directly on main via:

git merge -s ours dspace-7.6.1
git push upstream main

See db08e48

@tdonohue tdonohue closed this Jun 20, 2024
@tdonohue tdonohue deleted the main_synched_with_7.6.1 branch June 20, 2024 19:32
@tdonohue tdonohue added this to the 8.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Merge of DSpace 8 codebase on DSpace 7.6.1+ tag results in conflict