Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dspace 7 2695 #3104

Open
wants to merge 3 commits into
base: dspace-7_x
Choose a base branch
from

Conversation

VictorHugoDuranS
Copy link
Contributor

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Add listed results for home search, considering item with thumbnails and without thumbnails

Instructions for Reviewers

I added un number for the results of the search considering the current page and items par page

List of changes in this PR:

  • I added the get function named 'isValidForShowItemNumbered' in object-list.component.ts for valid if show the number
  • I added the get function named 'getNumber' in 'object-list.component.ts' for return the number considering the previous validation

For watch the change, only go to home and search anything. I attached a example

Example:
Captura de pantalla 2024-06-06 a la(s) 10 20 00 a m

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant