[Port 8.x] Fix for not all CREATE/DELETE Relationship requests coming through, during submission entity lookup #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove (de)select all buttons in DynamicLookupRelationSearchTab - add requestQueue to RelationshipEffects
…ip-effects-queue' into w2p-112198_add-relationship-effects-queue-main Conflicts: src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.spec.ts src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/relationship.effects.ts src/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/search-tab/dynamic-lookup-relation-search-tab.component.html
8 tasks
nona-luypaert
added
bug
component: submission
component: configurable entities
tdonohue
approved these changes
May 14, 2024
There was a problem hiding this comment.
👍 Thanks @nona-luypaert ! I've tested this with main and can verify that the Submission UI now sends one request at a time when adding/removing relationships. Code looks good too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
8.x port of #2841
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.