Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set color black on filter section for mobile #3035

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

VictorHugoDuranS
Copy link
Contributor

Hi @tdonohue, I'm @jtimal partner, I like to share this PR with you:

References

Description

I change the color for the text in the section of filters on search view

Instructions for Reviewers

I used tailwind for fix that bug and i was able replicated that bug on emulator IOS using Iphone 14 PRO MAX

List of changes in this PR:

  • First set color black default on text in filter section
  • Second set color white default on text in filter section when the phone has mode dark on, this validation was by tailwind

Evidences:
Bug replicated
image

Fix applicated
image

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release labels May 10, 2024
@tdonohue tdonohue requested a review from artlowel August 8, 2024 14:50
Copy link
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Aug 29, 2024
@tdonohue tdonohue merged commit b00470a into DSpace:dspace-7_x Aug 29, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for main:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue added this to the 7.6.3 milestone Aug 29, 2024
@tdonohue tdonohue removed port to main This PR needs to be ported to `main` branch for the next major release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug
Projects
Development

Successfully merging this pull request may close these issues.

4 participants