Add HTML support on system-wide alert (Fixes #3019)

[abelgomez]

References

• Fixes HTML support on system-wide-alert #3019.

Description

Adds HTML support to the system-wide alert banner.

Instructions for Reviewers

The commit only includes two simple changes, as explained in #3019 (comment).

In a second commit (I did it in a separate commit to ease the PR review), I also reformatted the code of the HTML templates, since the indenting was a bit mangled.

To test, log in as an admin, and set a system-wide alert message with HTML code in it.

Some examples of the result:

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[AgustinAlfieri]

Just tested this, I can add HTML to the system-wide alert banner but It gave me problems trying to set up a timer:

---

The issue persists even if I don't use HTML on the form:

---

If I roll back the changes, the timer works just fine:

[abelgomez]

Can anybody else try this PR?

I cannot reproduce the misbehavior with the timer... 😞

[AgustinAlfieri]

Just in case this is why, I tested using yarn start:dev not by doing the yarn build.

[abelgomez]

I also tested this PR in the dev environment with yarn start:dev using the main branch of DSpace 8.

But I deployed this patch in a stable server running DSpace 7.6/7.6.1 months ago without issues: https://biblioteca.sistedes.es

[AgustinAlfieri]

Just re-tested, it works perfectly. Sorry I had something else generating the problem.

[abelgomez]

No worries! Great! ☺🤗

[tdonohue]

👍 Thanks @abelgomez ! Tested this today and it works well. It's a very simple change (basically a "one-liner" style bug fix), so I'm going to also port this back to 7.x

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Add HTML support on system-wide alert (Fixes #3019) #3044