Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError: Cannot read properties of undefined (reading 'userAgent') #3004

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix TypeError: Cannot read properties of undefined (reading 'userAgent') #3004

merged 1 commit into from
May 3, 2024

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented May 3, 2024

References

Description

Fix bug where "navigator" may be null in SSR mode

Instructions for Reviewers

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels May 3, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 3, 2024
@tdonohue tdonohue mentioned this pull request May 3, 2024
Closed
tdonohue
tdonohue commented May 3, 2024
View reviewed changes
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this has fixed the error locally and in e2e tests (where it clutters test data), I'm going to merge this immediately. It's a one-character, obvious fix.

@tdonohue tdonohue merged commit 2a422ba into DSpace:main May 3, 2024
13 checks passed
@tdonohue tdonohue deleted the fix_3000 branch May 3, 2024 15:19
dsteelma-umd added a commit to dsteelma-umd/dspace-angular that referenced this pull request Sep 26, 2024
@dsteelma-umd
LIBDRUM-872. Back-port DSpace 8.0 fix for admin sidebar text cutoff
b4bdc79 
The following is an adaption of the DSpace 8.0 fix in the following
pull requests for use in DSpace 7.6.2:

* DSpace#2976
* DSpace#3004

The basic change is the same (detecting the browser and applying a
particular CSS change for Firefox), but the files that are modified
are different, due to changes in DSpace 8.0.

https://umd-dit.atlassian.net/browse/LIBDRUM-872
dsteelma-umd added a commit to dsteelma-umd/dspace-angular that referenced this pull request Oct 4, 2024
@dsteelma-umd
LIBDRUM-872. Back-port DSpace 8.0 fix for admin sidebar text cutoff
f8ba1d1 
The following is an adaption of the DSpace 8.0 fix in the following
pull requests for use in DSpace 7.6.2:

* DSpace#2976
* DSpace#3004

The basic change is the same (detecting the browser and applying a
particular CSS change for Firefox), but the files that are modified
are different, due to changes in DSpace 8.0.

https://umd-dit.atlassian.net/browse/LIBDRUM-872
@dsteelma-umd dsteelma-umd mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tdonohue tdonohue

Labels
1 APPROVAL pull request only requires a single approval to merge bug
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

SSR error appears on each page: TypeError: Cannot read properties of undefined (reading 'userAgent')
1 participant
@tdonohue