Skip to content

Commit

Permalink
Merge pull request #3051 from tdonohue/port_2944_to_7x
Browse files Browse the repository at this point in the history
[Port dspace-7_x] Disable inlineCriticalCss by default for better SSR performance
  • Loading branch information
tdonohue authored May 15, 2024
2 parents dfc304f + eeb562d commit 432692e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions config/config.example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ universal:
# Whether to inline "critical" styles into the server-side rendered HTML.
# Determining which styles are critical is a relatively expensive operation;
# this option can be disabled to boost server performance at the expense of
# loading smoothness.
inlineCriticalCss: true
# loading smoothness. For improved SSR performance, DSpace defaults this to false (disabled).
inlineCriticalCss: false

# The REST API server settings
# NOTE: these settings define which (publicly available) REST API to use. They are usually
Expand Down
2 changes: 1 addition & 1 deletion src/environments/environment.production.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ export const environment: Partial<BuildConfig> = {
preboot: true,
async: true,
time: false,
inlineCriticalCss: true,
inlineCriticalCss: false,
}
};
3 changes: 2 additions & 1 deletion src/environments/environment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export const environment: BuildConfig = {
universal: {
preboot: true,
async: true,
time: false
time: false,
inlineCriticalCss: false,
},

// Angular Universal server settings.
Expand Down
2 changes: 1 addition & 1 deletion src/environments/environment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const environment: Partial<BuildConfig> = {
preboot: false,
async: true,
time: false,
inlineCriticalCss: true,
inlineCriticalCss: false,
}
};

Expand Down

0 comments on commit 432692e

Please sign in to comment.