Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2397 make vt work with fmt 11 and integrate it if possible #2399

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

2397 make vt work with fmt 11 and integrate it if possible #2399

wants to merge 8 commits into from

Conversation

lifflander
Copy link
Collaborator

Fixes #2397

@lifflander lifflander linked an issue Feb 7, 2025 that may be closed by this pull request
Make VT work with fmt 11 and integrate it if possible #2397
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025 •
edited
Loading

Pipelines results

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-13, alpine, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

FAILED: src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx.o 
/usr/bin/ccache /nvcc_wrapper/build/nvcc_wrapper -DFMT_LOCALE -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DVT_NO_COLOR_ENABLED -I/vt/lib/CLI -I/build/vt/release -I/vt/src -I/vt/lib/json/include -I/vt/lib/brotli/c/include -isystem /vt/lib/EngFormat-Cpp/include -isystem /build/checkpoint/install/include -isystem /vt/lib/yaml-cpp/include -Wno-deprecated-gpu-targets -O3 -DNDEBUG -Wall -Wextra -Wno-unknown-pragmas -Wnon-virtual-dtor -Wshadow -Wsign-compare -Wsuggest-override -pedantic -ftemplate-backtrace-limit=100 -Werror -std=c++17 -MD -MT src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx.o -MF src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx.o.d -o src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx.o -c /build/vt/src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx
In file included from /vt/src/vt/epoch/epoch_type.h:50,
                 from /vt/src/vt/configs/types/types_headers.h:52,
                 from /vt/src/vt/configs/debug/debug_print.h:47,
                 from /vt/src/vt/configs/debug/debug_masterconfig.h:55,
                 from /vt/src/vt/config.h:47,
                 from /vt/src/vt/context/context.h:50,
                 from /vt/src/vt/context/context.cc:44,
                 from /build/vt/src/CMakeFiles/vt.dir/Unity/unity_19_cxx.cxx:3:
/build/vt/release/vt/cmake_config.h:101:28: fatal error: fmt/base.h: No such file or directory
  101 |   #define INCLUDE_FMT_BASE <fmt/base.h>
      |                            ^
compilation terminated.
FAILED: src/CMakeFiles/vt-trace.dir/vt/trace/trace_lite.cc.o 
/usr/bin/ccache /nvcc_wrapper/build/nvcc_wrapper -DFMT_LOCALE -I/vt/src -I/build/vt/release/vt-trace -isystem /vt/lib/EngFormat-Cpp/include -isystem /vt/lib/yaml-cpp/include -Wno-deprecated-gpu-targets -O3 -DNDEBUG -fdiagnostics-color=always -std=c++17 -MD -MT src/CMakeFiles/vt-trace.dir/vt/trace/trace_lite.cc.o -MF src/CMakeFiles/vt-trace.dir/vt/trace/trace_lite.cc.o.d -o src/CMakeFiles/vt-trace.dir/vt/trace/trace_lite.cc.o -c /vt/src/vt/trace/trace_lite.cc
In file included from /vt/src/vt/epoch/epoch_type.h:50,
                 from /vt/src/vt/configs/types/types_headers.h:52,
                 from /vt/src/vt/configs/debug/debug_print.h:47,
                 from /vt/src/vt/configs/debug/debug_masterconfig.h:55,
                 from /vt/src/vt/config.h:47,
                 from /vt/src/vt/trace/trace_log.h:47,
                 from /vt/src/vt/trace/trace_lite.h:49,
                 from /vt/src/vt/trace/trace_lite.cc:44:
/build/vt/release/vt-trace/vt/cmake_config.h:101:28: fatal error: fmt/base.h: No such file or directory
  101 |   #define INCLUDE_FMT_BASE <fmt/base.h>
      |                            ^
compilation terminated.
FAILED: src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx.o 
/usr/bin/ccache /nvcc_wrapper/build/nvcc_wrapper -DFMT_LOCA%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 9ab5ec3 (2025-02-14 00:39:06 UTC)

Build failed for unknown reason. Check build logs

Build log

cz4rs
cz4rs reviewed Feb 7, 2025
View reviewed changes
src/vt/timing/timing_type.h
@@ -164,6 +170,10 @@ struct TimeTypeWrapper {
TimeTypeInternal time_;
};

inline auto format_as(TimeTypeWrapper t) {
return to_engineering_string(t.seconds(), 5, eng_exponential, "s");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could avoid including EngFormat-Cpp/eng_format.hpp in the header by moving the implementation to .cpp.

@cz4rs cz4rs mentioned this pull request Feb 7, 2025
Open
cz4rs
cz4rs approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice +/- ratio for vt code 👍

Git check complains:

 lib/fmt/CMakeLists.txt:411: new blank line at EOF.
tests/unit/lb/test_lbargs_enum_conv.nompi.cc:166: new blank line at EOF.

@lifflander lifflander force-pushed the 2397-make-vt-work-with-fmt-11-and-integrate-it-if-possible branch from 9ab5ec3 to 46f7d98 Compare March 3, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cz4rs cz4rs cz4rs approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@cwschilly cwschilly Awaiting requested review from cwschilly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make VT work with fmt 11 and integrate it if possible
2 participants
@lifflander @cz4rs