#507: Deprecate LBAF-Viz and replace with calls to vt-tv #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppebay
requested changes
May 17, 2024
There was a problem hiding this comment.
When using some provided configuration files (e.g. conf.yaml), the following error occurs as expected, but it would be better to clean up all configuration decks in the conf directory, to ensure that they all indeed can be used as working examples
Traceback (most recent call last):
File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/Applications/LBAF_app.py", line 605, in <module>
LBAFApplication().run()
File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/Applications/LBAF_app.py", line 574, in run
visualizer = Visualizer(
File "/Users/pppebay/Documents/Git/LB-analysis-framework/src/lbaf/IO/lbsVisualizer.py", line 47, in __init__
raise DeprecationWarning("LBAF's Visualizer has been deprecated and will be removed in a future release. Visualizations should be generated with DARMA/vt-tv.`
Of course incorrect inputs can and should remain in the CI in order to test the above failure mode.
ppebay
reviewed
May 18, 2024
ppebay
requested changes
May 18, 2024
There was a problem hiding this comment.
I suggest also adding an extra test in tests/unit/config with a configuration deck that contains, e.g., the following block:
visualization:
x_ranks: 2
y_ranks: 2
z_ranks: 1
object_jitter: 0.5
rank_qoi: None
object_qoi: None
force_continuous_object_qoi: true
output_visualization_dir: ../../output
output_visualization_file_stem: output_file
in order to exercise the deprecation stop.
N.B.: this is not to replace the test_lbs_visualizer_deprecation.py in-code deprecation check, but in addition to it.
cwschilly
force-pushed
the
507-deprecate-lbaf-viz-and-replace-with-calls-to-vt-tv
branch
from
2278265 to
4238367
Compare
cwschilly
deleted the
507-deprecate-lbaf-viz-and-replace-with-calls-to-vt-tv
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
* #507: add deprecate error to lbsVisualizer * #507: add test for deprecation warning * #507: remove all references to visualization in unit test config files * #507: add newline * #507: remove viz params from all config files * #507: add config file test for lbaf viz deprecation * #507: remove config file test; clean up viz deprecation * #507: restore config test for viz deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
PR #463 implements the vt-tv pipeline and removes the call to lbsVisualizer in
LBAF_App.py.