Feat pauli decomposition #123
Conversation
…pqp into feat-pauli-decomposition � Conflicts: � mpqp/tools/ptdr.py
…pqp into feat-pauli-decomposition � Conflicts: � mpqp/tools/ptdr.py
…eat-pauli-decomposition
…coefficients (scaled apparently)
…eat-pauli-decomposition # Conflicts: # mpqp/tools/ptdr.py
…pqp into feat-pauli-decomposition � Conflicts: � mpqp/tools/ptdr.py
…eat-pauli-decomposition
| self.nY = parent.nY + 1 if atom is Y else parent.nY | ||
|
|
||
| @property | ||
| def childI(self) -> "PauliNode": |
There was a problem hiding this comment.
do we need to store these as children ? to me instead of having a generic children list, when we can directly have the right children in the node ?
There was a problem hiding this comment.
You mean that we could define a method like this
def set_children(children: tuple[PauliNode, PauliNode, PauliNode, PauliNode]):
self.childI = children[0]
self.childX = children[1]
self.childY = children[2]
self.childZ = children[3]And then remove the properties ?
This will avoid the usage of a list indeed, but then the treatments for each children will require the duplication of 4 lines ?
| def test_pauli_to_matrix( | ||
| list_matrix_pauli_string: list[tuple[npt.NDArray[np.complex64], PauliString]], | ||
| ): | ||
| for matrix, ps in list_matrix_pauli_string: |
There was a problem hiding this comment.
lol, seeing the for loop, I realize that my advice wasn't such a good one, I should have experimented with it before telling you about it, we'll work on it after the coming release
There was a problem hiding this comment.
Yeah, maybe you can create a trello task, and resolve this comment afterwards
|
once we merge Julien's branch on this one, we can go ahead and merge this PR, there is still some work to do here but it can be done later on |
…ITD-SAS/mpqp into fix-Pauli-Monomial-Symbol
…fication + removing numba
…ITD-SAS/mpqp into fix-Pauli-Monomial-Symbol
Fix pauli monomial symbol
No description provided.