Re-create .xib with auto-layout. Support 3x asset. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the system awares of 3x content makes us need to create launchscreens for 4.7, and 5.5' of iphone too. Re-layout to add support for auto-layout, and properly show the content for all devices.
It works with all iphone devices type, but doesn't work for iPad 2. The position of CALayer cannot be changed, this might due to the constraints imposed in the Interface builder. 3x asset is created from 2x asset thus it doesn't look high quality. Re-created as well the .xib for ViewController to support auto layout and show it correctly.
In .xib of ViewController, changed to use UIView instead of UIImageView.
Re-export 3x asset with scaling factor of 1.5 (or 3/2) from 2x asset via TexturePacker. But 3x asset will be scaled down by 15% (divide by 1.15) to fit iPhone 6+ screen at the end. Thus the actual scaling factor in effect is 1.5/1.15 = 1.30434782609 (~1.30). Then from scaling factor used in CAWSpriteCoreLayer to scale down from retina screen is 0.5. It increases to 0.5*1.3 = 0.65 or 15%. This means in final, we have a bigger scaling factor; that is 0.5 - 0.15 = 0.35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I re-created UI to support auto-layout thus UI will looks okay for all devices.
I added 3
UIViewto act as a parent view before we add those layers individually. This to give more control over positioning and management in the long run.Added support for iPhone 6+ with 3x asset. I simply created 3x asset using TexturePacker with scaling factor of 3/2 (or 1.5). For internal of layer class, I check for
[UIScreen mainScreen].scale == 3.0or not, if so then use scale of0.35. You can read more information at commit log of 42bde5dIssues
Anyway, something weird going on.
I don't think it's due to auto-layout because
CALayerwhich we're working with doesn't get effect by it. I just can't modify layer's position, yes, and only position. No matter what I do, it don't get into effect. The layer will be fixed at top right of its attaching view. See more atViewController.m.Another one is, if we use
INFINITYon iOS 9, the animation's display frame will disappear sometime during the animation, with also when we interact with buttons to pause, continue, stop, and play animation. I changed to use hard-coded high value instead and it works fine.Result
Tested on iPod Gen 5, and all simulators iOS 9 works as expected except for iPad 2 which will give weird result of positioning.
Result as follows.
