Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pr template #140

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add pr template #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07f686
Add PR template
classiqdor Jun 6, 2024
b511557
Minor fix
classiqdor Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
### PR Description

<!-- Describe the PR's general purpose -->

### Some notes

- [ ] Please make sure that you placed the files in an appropriate folder
- [ ] And that the files have indicative names.

- [ ] Please note that Classiq runs automatic code linting, which may minorly alter some files.
- [ ] If you're familiar with `pre-commit`, you may run `pre-commit install`, and then at each commit, your files will be altered in a similar way
2 changes: 1 addition & 1 deletion tests/utils_for_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def iterate_notebooks() -> Iterable[str]:
return notebooks_to_test


def _get_all_notebooks(directory=ROOT_DIRECTORY) -> Iterable[str]:
def _get_all_notebooks(directory: Path = ROOT_DIRECTORY) -> Iterable[str]:
for root, _, files in os.walk(directory):
for file in files:
if file.endswith(".ipynb"):
Expand Down