-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW-aware synthesis capability #116
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qubit1718 Great work!
See my comments, there are small fixes needed
Hi @orsa-classiq, Thank you so much for taking your time and reviewing the PR. I will work on these comments and update the notebook as soon as possible :)) |
Hi @orsa-classiq, I made all the required changes. Can you please check now? Please let me know if you still find anything inappropriate. Hope to hear from you soon :)) |
@Qubit1718 That's great. There is just a small thing with the plotting that I was probably not enough clear about. I want it to be plotted (e.g. with matplotlib). |
Can you please be a bit more specific, @orsa-classiq ? Should I plot the output of CX gates against the depth? or should I plot the grid connectivity using matplotlib? |
plot the grid connectivity :) |
Thanks for the quick reply, I will work on it and update the file soon. Thanks :)) |
Hi @orsa-classiq, The new commit includes the connectivity graphs using matplotlib and networkx. Can you please review it? I look forward to seeing the PR merged :)) |
Hi @orsa-classiq, Thanks for approving the changes. Could please also let me know if there anything more that i need to do from my end to get the PR merged? And the next steps if any. |
Sorry, I approved and then realized there are additional changes needed:
Then I will take care for the merge |
Hi @orsa-classiq , Completed the required changes. Please go through them and let me know if there are any additional changes required. |
This will close the issue #41