Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add positive and negative test cases #167

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

massfords
Copy link
Collaborator

@massfords massfords commented Dec 29, 2024

closes: #165

@massfords
Copy link
Collaborator Author

😞 unsure what the problem is here. This commit lint rule keeps failing.

@massfords massfords marked this pull request as ready for review December 29, 2024 19:31
@OranShuster
Copy link

OranShuster commented Jan 7, 2025

@massfords i think you need to add a blank line in the commit message above the Closes... line

@massfords
Copy link
Collaborator Author

massfords commented Jan 7, 2025

@massfords i think you need to add a blank line in the commit message above the Closes... line

Thanks for the prod. I tried adding a line above the closes but it still failed. However, I noticed that I was getting a warning in the console about the commit rule failing which I hadn't noticed before. I removed that line entirely and it worked.

Maybe I need to keep my commits messages to a single line?

Anyway, thanks for the suggestion, it got me to look at this again.

Copy link
Owner

@ChristopheBougere ChristopheBougere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for all the troubles with commitlint :/

The reason why I'd prefer to keep it is that it ensure semantic release can generate proper releases in Github and choose the type of version (major/minor/patch) depending on what's included. I could also remove commitlint and always squash and reword the commit, but I find it more risky.

I don't know much how to help you because it always worked pretty well for me, but if keeping your messages to a single line works for you, it can be a workaround...
Otherwise drop me a mail (address on my profile) and we can try to debug it live.

Thanks for the contribution anyway!

@ChristopheBougere ChristopheBougere merged commit 899492d into ChristopheBougere:main Jan 11, 2025
1 check passed
Copy link

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation failed on field using intrinsic functions
3 participants