feat: support new fields for variables #162
Conversation
| "asl-path-validator": "^0.14.2", | ||
| "asl-path-validator": "^0.15.0", |
There was a problem hiding this comment.
new version supports variables in JSONPath expressions and also adds a new format type for ResultPath fields which are ReferencePath expressions but cannot contain variables.
| }, | ||
| "Condition": { | ||
| "$ref": "jsonata.json#/definitions/condition" |
There was a problem hiding this comment.
In a JSONata Choice State, each Choice Rule MUST have a "Condition" field. The "Condition" field accepts a boolean value or a JSONata string that must evaluate to a boolean value.
| "ResultPath": { | ||
| "$ref": "paths.json#/definitions/asl_ref_path" | ||
| "$ref": "paths.json#/definitions/asl_result_path" |
There was a problem hiding this comment.
In a JSONPath state, the "ResultPath" field MUST NOT reference a variable.
I added a new format type in asl-path-validator to support this
| }, | ||
| "QueryLanguage": { | ||
| "$ref": "jsonata.json#/definitions/queryLanguage" |
There was a problem hiding this comment.
A state machine specifies its query language in the top-level "QueryLanguage" field, which overrides the default and sets the query language for every state in the state machine.
massfords
force-pushed
the
mf/variables
branch
from
7568ec9 to
5c7c292
Compare
|
@ChristopheBougere I'm still not sure what I'm doing wrong with these commit messages. I've got the latest repo, ran install, and did the build before making any changes. My initial commit had a leading blank line but I suspect Webstorm trimmed it. I did a Anyway, if you can take a look and fix it would be appreciated. I think this is a good first pass at supporting the new variables/JSONata feature. There's a fair amount of additional work with respect to validating the JSONata expressions and ensuring that the referenced variables are in scope. There's also other validation like checking the length and naming rules for variables introduced in |
chore: bump asl-path-validator version chore: npm audit fix
Sure I will amend the commit message It might be because you squashed your commits and the new commit message wasn't well formatted, or something like this |
ChristopheBougere
force-pushed
the
mf/variables
branch
from
5c7c292 to
d358199
Compare
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chore: bump asl-path-validator version
chore: npm audit fix
closes: #161
This is the minimum to support the new variables fields