-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove support for CJS #440
Conversation
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
@@ -3,21 +3,16 @@ | |||
"version": "0.19.1", | |||
"description": "Persistent data structures for TypeScript.", | |||
"type": "module", | |||
"main": "./lib/cjs/index.js", | |||
"module": "./lib/index.js", | |||
"main": "./lib/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package needs subpath exports for the as-sha256 hasher and the setHasher function, see https://github.com/ChainSafe/lodestar/pull/7387/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to add extra named exports in a separate PR to have clarity in the change logs. What do you think?
Motivation
Remove support for the CJS build
Description
Closes #439
Steps to test or reproduce