feat(internal/client) GossipEngine implementation with dependency Network and Syncing interfaces
#4572
Conversation
timwu20
force-pushed
the
tim/gossip-engine
branch
from
4d0f119 to
8d9a1bc
Compare
timwu20
force-pushed
the
tim/gossip-engine
branch
from
d40d5fa to
26ec185
Compare
timwu20
force-pushed
the
tim/gossip-engine
branch
from
26ec185 to
ba5deda
Compare
timwu20
changed the title
GossipEngine implementation with dependency Network and Syncing interfaces
timwu20
requested review from
EclesioMeloJunior and
jimjbrettj
as code owners
| ) | ||
|
|
||
| // Multiaddr type used in Gossamer | ||
| type Multiaddr struct { |
There was a problem hiding this comment.
why Multiaddr wrapped in Multiaddr?
There was a problem hiding this comment.
We will eventually need to implement some public methods on this type in future work (see substrate impl). Just laying the groundwork for now.
| ge.stateMachine.BroadcastTopic(ge.notificationService, topic, force) | ||
| } | ||
|
|
||
| // Get data of valid, incoming messages for a topic (but might have expired meanwhile). |
There was a problem hiding this comment.
Why we are not using go semantc comments that start with the name of upcoming identifier declaration? In future it can be used for godoc
There was a problem hiding this comment.
They actually stopped enforcing this in the linter, but I'll update this one since I still try to adhere to the practice.
There was a problem hiding this comment.
Ended up updating a lot of comments based on this practice in bedf0f8.
|
|
||
| // MultiaddrPeerId is the address of a node, including its identity. | ||
| // This struct represents a decoded version of a multiaddress that ends with "/p2p/<peerid>". | ||
| type MultiaddrPeerId struct { |
There was a problem hiding this comment.
why have separate package config for this?
There was a problem hiding this comment.
That's where it's found in substrate (link). There will be more config associated types added to this package in future work.
Changes
GossipEngineimplementation.service.NetworkPeers,service.NetworkEventStream,sync.SyncEventStream, andservice.NetworkBlockinterfaces.gossip.Networkandgossip.Syncinginterfaces as dependencies forGossipEngine.NetworkandSyncingimplementations.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #3629