feat: add SessionGridTopology and dependencies to calculate neighbours #4551
+555
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1sar
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
EclesioMeloJunior
requested changes
Feb 21, 2025
Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add SessionGridTopology
Add 2D matrix Neighbours calculations
Add sessionGridToplogyStorage
Added all necessary GridTopology methods for statement distribution.
Cut couple corners with not implementing functions that are not used anywhere + haven ot implemented RandomRouting, it is rather should be implemented within Bitfield distribution or ApprovalDistribution.
As well as I have not implemented SessionGridTopologies but those used only in ApprovalDistribution which is out of scope for Validator MVP.
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Closes: #4454