Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(status): Add snapshot progress RPC #5368

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akaladarshi
Copy link
Contributor

@akaladarshi akaladarshi commented Mar 3, 2025

Summary of changes

Changes introduced in this pull request:

  • Create an Appcontext in daemon to hold common objects
  • Create SnapshotTracket to track the snapshot progress
  • Expose a RPC API Filecoin.SyncStatus which reports the snapshot download progress

Reference issue to close (if applicable)

Closes: #4929

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@akaladarshi
Copy link
Contributor Author

akaladarshi commented Mar 3, 2025

@LesnyRumcajs @elmattic Please 🙏 can any one of give it a review.

This PR is not fully ready yet (naming, logging changes and need to remove extra command), just wanted to get some opinions on this, so I can proceed further.

Edit: To review only the snapshot progress tracker take a look at the last two commits

@LesnyRumcajs
Copy link
Member

I'll let @hanabi1224 or @lemmih take a look; I don't have the capacity currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate snapshot download in sync status
2 participants