-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): make data field in EthCallMessage optional #5357
base: main
Are you sure you want to change the base?
Conversation
1108d6a
to
0896b12
Compare
|
||
let bytes = decode_payload(&msg_rct.return_data(), CBOR)?; | ||
Ok(bytes) | ||
let return_data = msg_rct.return_data(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if msg.To == builtintypes.EthereumAddressManagerActorAddr {
return ethtypes.EthBytes{}, nil
} else if len(invokeResult.MsgRct.Return) > 0 {
return cbg.ReadByteArray(bytes.NewReader(invokeResult.MsgRct.Return), uint64(len(invokeResult.MsgRct.Return)))
}
return ethtypes.EthBytes{}, nil
0896b12
to
44442fd
Compare
…tional-in-eth-call-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog entry?
…tional-in-eth-call-message
@LesnyRumcajs added. |
CHANGELOG.md
Outdated
@@ -112,6 +112,8 @@ | |||
|
|||
- [#5213](https://github.com/ChainSafe/forest/issues/5213) Fix incorrect results for the `Filecoin.EthGetLogs` RPC method on ranges that include null tipsets. | |||
|
|||
- [#5357](https://github.com/ChainSafe/forest/issues/5357) Make data field in EthCallMessage optional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't helpful to the changelog reader - it's an implementation detail. What would be beneficial is mentioning the RPC methods affected by this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Co-authored-by: Hubert <hubert@chainsafe.io>
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #5352
Other information and links
Change checklist