Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct eth_call serialising + contract test #5332

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Feb 24, 2025

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 24, 2025 19:17
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner February 24, 2025 19:17
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and elmattic and removed request for a team February 24, 2025 19:17
@elmattic
Copy link
Contributor

What is the rationale for supporting the Ethereum API? Do we want to extend this to other eth_xxx methods as well?

@LesnyRumcajs
Copy link
Member Author

What is the rationale for supporting the Ethereum API? Do we want to extend this to other eth_xxx methods as well?

In general, the entire eth_ is there to support the Ethereum API. We want to support it as closely as possible, which usually means supporting what Lotus supports (but potentially having better support if it doesn't break compatibility between Forest and Lotus).

@elmattic elmattic added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 6a4480a Feb 25, 2025
49 checks passed
@elmattic elmattic deleted the fix-eth-call branch February 25, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants