-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mirror filecoin built-in actors #344
Conversation
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirroring only the latest release is not useful. The goal is to mirror all releases, properly versioned. The end structure of the mirror should be like (though more complete):
├── v10.0.0
│ ├── builtin-actors-devnet.car
│ └── builtin-actors-mainnet.car
├── v10.0.0-rc.1
│ └── builtin-actors-calibrationnet.car
├── v11.0.0
│ ├── builtin-actors-devnet.car
│ └── builtin-actors-mainnet.car
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
How about caching the installation itself: https://github.com/snok/install-poetry?tab=readme-ov-file#caching-the-poetry-installation There are also useful guides on how to cache deps in the above readme too. |
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
@samuelarogbonlo I appreciate the effort of making it enterprise-grade, but a simple lambda would do enough for having a configurable sink. We're getting into non-trivial Python code where we shouldn't. Pseudocode of what I mean:
You also added quite a bit of unused methods. Let's keep things as simple as possible. |
I think there is exactly one unused method: |
If you guys are okay with that, then I won't block it. |
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
@LesnyRumcajs. Good? |
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
Signed-off-by: samuelarogbonlo <sbayo971@gmail.com>
I kinda get where you are coming from, but I don't see a better way here. This is not too advanced, just using some OOP that happens to be quite ugly in Python :) |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #323
Other information and links