Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request faucet top-up on low balance #135

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Feb 3, 2025

Summary of changes

Changes introduced in this pull request:

  • Show a Request Faucet Top-up option instead of send button if available faucet balance is less than network drip amount
    image

Reference issue to close (if applicable)

Closes #129

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 9.95%. Comparing base (b49448a) to head (b8c9bbc).

Files with missing lines Patch % Lines
src/faucet/views.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #135      +/-   ##
=========================================
- Coverage   10.02%   9.95%   -0.07%     
=========================================
  Files          25      25              
  Lines        1287    1296       +9     
=========================================
  Hits          129     129              
- Misses       1158    1167       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sudo-shashank sudo-shashank marked this pull request as ready for review February 3, 2025 13:58
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 3, 2025 13:58
@sudo-shashank sudo-shashank changed the title Request faucet top-up button on low balance Request faucet top-up on low balance Feb 3, 2025
@LesnyRumcajs
Copy link
Member

I like the button idea. I would've done it differently (block the send button and mention the top-up link in the description), but I think your approach is more user-friendly.

@sudo-shashank sudo-shashank marked this pull request as draft February 4, 2025 09:30
@sudo-shashank sudo-shashank marked this pull request as ready for review February 4, 2025 12:25
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit f69b38a Feb 4, 2025
5 checks passed
@LesnyRumcajs LesnyRumcajs deleted the shashank/add-faucet-topup-req branch February 4, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No result" error when requesting FIL from mainnet faucet.
3 participants