Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address test data race #119

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: address test data race #119

merged 2 commits into from
Jan 17, 2025

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 17, 2025

Summary of changes

Changes introduced in this pull request:

  • this fixes a datarace in tests. It can be reproduced by running cargo test repeatedly in a loop, e.g., 50 iterations.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 17, 2025 08:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (6eeb504) to head (e7d5da5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   10.44%   10.30%   -0.15%     
==========================================
  Files          25       25              
  Lines        1254     1252       -2     
==========================================
- Hits          131      129       -2     
  Misses       1123     1123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lemmih
lemmih previously approved these changes Jan 17, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 17, 2025
@LesnyRumcajs LesnyRumcajs removed this pull request from the merge queue due to a manual request Jan 17, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 9ced379 Jan 17, 2025
5 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-datarace-change-network branch January 17, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants