Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fading messages #117

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Jan 15, 2025

Summary of changes

Changes introduced in this pull request:

  • Add support for fading (and disappearing) messages
  • Improve message display with the offensive address

Reference issue to close (if applicable)

Closes #89

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 10.44%. Comparing base (d11c14e) to head (0cf3d1c).

Files with missing lines Patch % Lines
src/faucet/views.rs 0.00% 34 Missing ⚠️
src/faucet/controller.rs 0.00% 8 Missing ⚠️
src/utils.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   10.72%   10.44%   -0.28%     
==========================================
  Files          25       25              
  Lines        1222     1254      +32     
==========================================
  Hits          131      131              
- Misses       1091     1123      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elmattic elmattic marked this pull request as ready for review January 15, 2025 15:39
@elmattic elmattic requested a review from a team as a code owner January 15, 2025 15:39
@elmattic elmattic added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 0a0327f Jan 16, 2025
5 checks passed
@elmattic elmattic deleted the elmattic/disappearing-messages branch January 16, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating messages should fade and disappear
4 participants