Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Solana documentation #349

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

phreppo
Copy link
Contributor

@phreppo phreppo commented Feb 5, 2025

No description provided.

@@ -29,8 +29,9 @@ For more details, see [Conf File](https://docs.certora.com/en/latest/docs/prover

## Modes of Operation

The Certora Solana Prover has two modes of operation, using a predefined build script, and passing precompiled binary directly.
The Certora Solana Prover has two modes of operation, using a build script, or passing a precompiled binary directly.
These modes are mutually exclusive - you cannot run the tool with more than one mode at a time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a third option - running from a .conf file, like we mention in SolanaExamples (certoraSolanaProver Default.conf). This mode doesn't require using the --rule flag but requires a rules item in the .conf file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that running from a configuration file is not really a mode of operation, as under the wood one of the two others is used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we explain about conf files in usage.md, so it is indeed not needed here.

@urikirsh urikirsh self-requested a review February 5, 2025 19:20
Copy link
Contributor

@urikirsh urikirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes

@phreppo phreppo merged commit 540ad29 into solana/docs_template Feb 6, 2025
2 checks passed
@phreppo phreppo deleted the phreppo/fixes branch February 6, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants