Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsupported --build_script flag #348

Closed
wants to merge 2 commits into from
Closed

Fix unsupported --build_script flag #348

wants to merge 2 commits into from

Conversation

phreppo
Copy link
Contributor

@phreppo phreppo commented Feb 4, 2025

No description provided.

@phreppo phreppo requested a review from urikirsh February 4, 2025 16:35
urikirsh
urikirsh requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@urikirsh urikirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but we also have a section titled --build_script that starts from line 35, can you please remove it? Maybe add it to a different branch so that we don't lose it - we will want to merge it right after the fix

@phreppo @urikirsh
Update docs/solana/options.md
1829d0f 
Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com>
@phreppo
Copy link
Contributor Author

phreppo commented Feb 5, 2025

The branch is here: https://github.com/Certora/Documentation/tree/phreppo/solana-section-with-script

@phreppo
Copy link
Contributor Author

phreppo commented Feb 5, 2025

Closing since the flag is now supported.

@phreppo phreppo closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urikirsh urikirsh urikirsh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phreppo @urikirsh