feat: Translate feature added and doesn't break previous tests, new t… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2025 14:43
|
Looks good to me! |
|
Looks good, probably just fix the lint! |
ajain-1
force-pushed
the
translation-feature
branch
from
0a095bb to
b34bda1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28
This pull request allows all users to translate a post from (almost) any language to English. NOTE: Since the API used was free (Google Translate), there could be slightly wrong translations.
Files changed:
node bb-theme-harmony/templates/partials/topic/post.tpl - Changed format to have a translate button if not in English
public/openapi/components/schemas/PostObject.yaml,
public/openapi/read/categories.yaml,
public/openapi/read/index.yaml,
public/openapi/read/topic/topic_id.yaml,
public/openapi/write/posts/pid.yaml,
public/openapi/write/posts/pid/replies.yaml,
public/src/client/topic.js -
All changed to store two variables: "english": boolean for if the post is english, "translation": string for the translation.
src/posts/create.js - Call and store translation API
src/translate/index.js - API function