Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changed files in en-US for frontend anon posts #33

Closed
wants to merge 1 commit into from

Conversation

lynzhlang
Copy link
Contributor

@lynzhlang lynzhlang commented Feb 9, 2025

WIP: only front end working so far! NOTE: PR IS NOT MERGED BECAUSE WE ARE NOT CONTINUING THIS FEATURE DUE TO TA FEEDBACK. See the Moving Forward section for more info.
Context
Resolves issues #12 and addresses #9. Addresses user stories for anonymous posting.

Description
Created a button for anonymous posting on any create post/reply page that is clickable. This sprint + update is purely frontend but the rest of the feature is not. Moving forward, we'd like to implement the backend including the permissions that determines of a user can see who posted an anonymous post.

Codebase Changes

  • ./node_modules/nodebb-plugin-composer-default/static/templates/partials/composer-formatting.tpl: insert a button list item that shows up on the frontend.
  • ./public/language/en-US/admin/manage/categories.json: define post-anonymously as a category management setting
  • ./public/language/en-US/admin/manage/privileges.json: list post-anonymously as a user privilege
  • ./public/language/en-US/modules.json: adds post-anonymously to the composer module
  • .gitignore: unignore the specific file we want to commit
    All changes can be seen in the PR except for the node_modules. Here is a screenshot because we could not figure it out. Yuki and I talked with multiple TAs and instructors and received different responses across the entire group, so we were not able to figure out how to commit our front end changes

    image

Additional Information
Ran lint and test and checked the front end. Had teammates pull code from my branch and manually insert my node_modules code to check that my changes work on other laptops (We couldn't figure out a better way to sync). Hovering over the button shows the label and we can see visually that the button functions.

Moving Forward
We are not continuing this feature. Our TAs gave us feedback during our reci presentation and asked us to merge our stories so that we can work in pairs rather than alone. Since this is the case, I will be working with Yuki on #32 moving forward.

Screenshot 2025-02-08 at 9 25 42 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13230205417

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.671%

Totals Coverage Status
Change from base Build 13003811197: 0.0%
Covered Lines: 22323
Relevant Lines: 25582

💛 - Coveralls

@jwjulie jwjulie assigned jwjulie and lynzhlang and unassigned jwjulie Feb 11, 2025
@jwjulie jwjulie added this to the Sprint 1 milestone Feb 11, 2025
@jwjulie jwjulie self-requested a review February 11, 2025 20:06
@lynzhlang lynzhlang requested a review from yukiiii04 February 11, 2025 22:39
@lynzhlang lynzhlang changed the title changed files in en-US for frontend anon posts [WIP]: Changed files in en-US for frontend anon posts Feb 11, 2025
@yukiiii04 yukiiii04 changed the title [WIP]: Changed files in en-US for frontend anon posts [WIP] Changed files in en-US for frontend anon posts Feb 12, 2025
@lynzhlang lynzhlang closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants