Cheyu/save to favorites toggle #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tu2463
force-pushed
the
cheyu/save-to-favorites-toggle
branch
4 times, most recently
from
598f2b3 to
a30980f
Compare
Pull Request Test Coverage Report for Build 11241928557Details
💛 - Coveralls |
tu2463
force-pushed
the
cheyu/save-to-favorites-toggle
branch
from
0a54684 to
b1b38bf
Compare
alicekang1
reviewed
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added backend code to switch the button between "Save to Favorites" and "Remove from Favorites" when clicking on it.
This fully resolves #1
The code currently only enables the button to switch, and this can be tested manually on the web page. See more details for testing at CMU-313/nodebb-frontend-f24-sweethearts#4 (commits)
However, the code doesn't actually save and remove the corresponding posts to the database. The test files are written to test if it can save the posts. Therefore, the tests can't be passed yet.