Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Endorsement Feature [Resolves issues #34 #6 #33 #26] #36

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

Nita242004
Copy link

@Nita242004 Nita242004 commented Oct 11, 2024

  • Setup the backend logic for the endorsement feature so that the correct fields will be changed when the endorse button is pressed
  • Configured the routes so that the user can press the endorse button and a star will appear on the right for the chosen post
  • Added unit tests to test the API call and ensure that the value is correctly changed
  • Implemented a responsive front end in nodebb-frontend-f24-aawaa for the endorse button

Resolves: #34 #6 #33 #26

New dropdown option for Endorse:
Screenshot 2024-10-10 at 9 53 18 PM

After pressing the endorse button and refreshing the page, a star appears to indicate which post was endorsed by the instructor:
Screenshot 2024-10-10 at 9 53 31 PM

Passed Unit tests:
Screenshot 2024-10-10 at 9 56 58 PM

@Nita242004 Nita242004 added the Endorsement feature This series of PRs/Issues are relating to the endorsement feature label Oct 11, 2024
@Nita242004 Nita242004 added this to the Sprint 2 milestone Oct 11, 2024
@Nita242004 Nita242004 self-assigned this Oct 11, 2024
Copy link

@evelynzhengg evelynzhengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Nita! If you could fix the linter errors, this is ready to merge.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear logic!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix linter errors

@Nita242004 Nita242004 changed the title Post Endorsement Feature [Resolves issues #34 #6 #10 #7 #33] Post Endorsement Feature [Resolves issues #34 #6 #33 #26] Oct 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11285170400

Details

  • 22 of 27 (81.48%) changed or added relevant lines in 6 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/posts.js 3 4 75.0%
src/posts/endorse.js 10 11 90.91%
src/controllers/write/posts.js 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
src/admin/versions.js 1 87.88%
src/controllers/admin/dashboard.js 2 73.82%
src/middleware/render.js 2 79.19%
Totals Coverage Status
Change from base Build 10778152084: -0.02%
Covered Lines: 22343
Relevant Lines: 25608

💛 - Coveralls

@Nita242004 Nita242004 merged commit da8a888 into f24 Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Endorsement feature This series of PRs/Issues are relating to the endorsement feature
Projects
None yet
3 participants