-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
real data and weights #39
base: master
Are you sure you want to change the base?
real data and weights #39
Conversation
…akes a preselection for ttbar events; Add branches isRealData and event_weight; Add small programs PupMCHistProd.py, PupWeightMaker.py and LHEcounter.py for computation of pileup weights and the effective event number for events with lhe weights
@davidwalter2 I went with more detail through the PR and there is quite some work to do before merging, but nothing it can't be solved with 1 or 1.5 weeks of dedicated work on your part. Please, during this time update this PR once every key item is done, do not delete and create a new one, it is quite useful to me to keep track of where we stand. There are no striking mistakes, but rather a lot of potentially harmful design choices for the future. Do not worry though, I can recognise them only because I made them myself in the past :). I would say we can start from the following:
That should be it for the moment, once the code is in a better shape I will have a second look around to see if anything else is missing or can be done better. Thanks! |
…DeepNTuples into RealDataAndWeights
@mverzett "you should compute at the beginning of your cfg how many events you process and then dump it in the root file (not the tree, somewhere else), so that we can keep track of the efficiency"
Thanks! |
@davidwalter2 sorry, I do not quite understand your statement:
Can you please clarify? What I would suggest you to do is to create a very simple analyzer that counts how many events it sees and at the end of the job drops that number into a TTree with one branch and one entry. The file merging then becomes trivial. You need to put such analyzer above everything in a different place because later on you might (and you will) apply a selection on the events. |
@mverzett Maybe we mean the same :D but I want to explain my thoughts. Anyway I have finished all points to my best ability, maybe you can look through it if you have the time. |
…moved selection specific configs to DeepNtuplizer_'selection'
…ght for better workflow; bug fixes
New PR for the domain adaption investigation.
Compared to the old PR, I cleaned a lot of things and simplified the processing steps.
In this file you have also the possibility to run on data or MC