Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_dims_of_t and replace_dims_of_t #559

Merged
merged 8 commits into from
Jul 25, 2024
Merged

remove_dims_of_t and replace_dims_of_t #559

merged 8 commits into from
Jul 25, 2024

Conversation

blegouix
Copy link
Collaborator

Types associated to remove_dims_of and replace_dims_of.

Necessary for a Gysela MR.

@blegouix blegouix self-assigned this Jul 22, 2024
@blegouix blegouix requested a review from tpadioleau July 22, 2024 07:49
tpadioleau
tpadioleau requested changes Jul 25, 2024
View reviewed changes
@blegouix @tpadioleau
Apply suggestions from code review
bd6992f 
Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
@blegouix blegouix marked this pull request as draft July 25, 2024 12:05
@blegouix blegouix marked this pull request as ready for review July 25, 2024 15:38
tpadioleau
tpadioleau approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@blegouix blegouix merged commit 2c4aae8 into main Jul 25, 2024
49 checks passed
@blegouix blegouix deleted the remove-and-replace-dims-of-t branch July 25, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegouix @tpadioleau