-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring compliance #323
Docstring compliance #323
Conversation
bringing back into drafts to implement |
* all functions now return instead of updating self * small bugfix * fixing mypy
…_init__.py, abstract_initializer.py, abstract_parameters.py, and config.py. Had to make many config functions private to avoid numpy comments on 1 liners
…in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few unimportant copyedits. I'm not sufficiently familiar with numpydoc
to assess this properly.
Propose adding numpydoc
check to the linter, which as discussed looks like we can just do with the --convention=numpy
flag?
…entions of methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and I'm sure it was tedious to go through. Thank you for setting a great example :). LGTM
next step will be to tackle the format of the docstringed Examples
and to add pydocstring
to pre-commit
pydocstyle
to ensure method comments follow PEP257 guidelinesself
from within the method.This PR will make future revamps easier and is a part of general repo maintenance in preparation for v1.0 overhaul.
Some functions were left untouched because they will likely be drastically changed by GH issues like #319 #321 #318 or are soon to be deprecated and removed.
CLOSES #313