Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding readme badges and pyproject author #317

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

arik-shurygin
Copy link
Collaborator

a small commit meant to work on #314 but not closing that yet until we set up auto changelogs on release, badges will now display the package version which can be incremented by each PR into main.

I am going to assume that we will transition into a staging-> production format where main will be reserved for each release and sets of PRs will be made into a staging branch before going out as a release in main. This has not been something we have been doing up to this point due to the early nature of the project.

@edbaskerville
Copy link
Collaborator

edbaskerville commented Jan 14, 2025

@arik-shurygin re: branches for release process, I'm reviewing the "Release Process" part of the Predict handbook, and it sounds somewhat different from what you were implying.

Copy link
Collaborator

@edbaskerville edbaskerville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except I was uncertain about the Azure badge--is the goal not to remove all Azure from this repo?

Also curious about author format.

@arik-shurygin
Copy link
Collaborator Author

@arik-shurygin re: branches for release process, I'm reviewing the "Release Process" part of the Predict handbook, and it sounds somewhat different from what you were implying.

I was unaware there was explicit guidance on this now here and here. We can get CHANGELOG to generate when deciding to go from main to staging.

@arik-shurygin
Copy link
Collaborator Author

arik-shurygin commented Jan 14, 2025

@edbaskerville do you think we need both of these badges? Maybe just the right one is enough
image

@arik-shurygin arik-shurygin merged commit 9cc21ae into main Jan 14, 2025
4 checks passed
@arik-shurygin arik-shurygin deleted the versioning-and-repo-best-practices branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants