Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing gitpython and cycler old packages #288

Merged
merged 1 commit into from
Oct 24, 2024
Merged

removing gitpython and cycler old packages #288

merged 1 commit into from
Oct 24, 2024

Conversation

arik-shurygin
Copy link
Collaborator

removes 2 old packages that are now unusued, also removes a copy of the README that snuck in when we reorganized things.

Still more work to do to reduce dependency size but it is a start.

edbaskerville
edbaskerville approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@edbaskerville edbaskerville left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from a clean clone via

git clone git@github.com:CDCgov/DynODE 2024-10-24-pr288-review
cd 2024-10-24-pr288-review
poetry install
. .venv/bin/activate
./examples/example_end_to_end_run.py
./examples/example_end_to_end_run.py --infer=true

Still works.

@arik-shurygin arik-shurygin merged commit d2fb41f into main Oct 24, 2024
3 checks passed
@arik-shurygin arik-shurygin deleted the dependency-management branch October 24, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbaskerville edbaskerville edbaskerville approved these changes

@kokbent kokbent Awaiting requested review from kokbent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arik-shurygin @edbaskerville