Adding the ConfigValidationError #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-shurygin
changed the title
kokbent
reviewed
Nov 5, 2024
| ( | ||
| val_func(key[0], vals[0]) | ||
| if len(key) | ||
| == 1 # convert back to floats if needed |
There was a problem hiding this comment.
seriously this line split is stupid thank you black :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new special class of error called the ConfigValidationError which wraps all our validation tests to return a special error message which is easier to understand rather than relying on simple AssertionErrors. This also means that critical errors to the config class itself are going to appear differently which could help with catching bugs.
I also added a brief test for the scenario in which a user identifies a STRAIN_IDX enum that is not equal in length to the number of strains they defined.
CLOSES #279