Run-able with more modern version of npm and node (npm 10.2.4, node 20.11.0) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I an instance of thorn but she isn't showing up so I'm not sure why currently but I can add the rest of the new operators and potentially their counters |
|
Nvm. I figured it out. I'm gonna add the rest of the new operators and then maybe their counters. |
|
Changes look really good! Thank you for contributing @lilyhuang-github ! Perhaps the minimum node version could be raised to v20.17.0 on the README now with the changes you have made? |
BurkusCat
approved these changes
Sep 26, 2024
|
No problem. I'll update the README alongwith adding the new operators and their counters. |
lilyhuang-github
added a commit
to lilyhuang-github/r6-operator-counters
that referenced
this pull request
Sep 27, 2024
Merge pull request BurkusCat#249 from lilyhuang-github/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I update some deprecated dependencies and updated file path from cjs syntax to esm syntax.
This would solve issue #207 .
It would still use a lot of changing but it runs.