fixup! feat: directional premiums for referrals

BoltzExchange · Mar 5, 2025 · 5b36106 · 5b36106
1 parent a232f75
commit 5b36106
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 45 deletions.
diff --git a/lib/db/models/Referral.ts b/lib/db/models/Referral.ts
@@ -6,10 +6,10 @@ type Limits = {
   maximal?: number;
 };
 
-type DirectionalPremium = {
+type DirectionalPremium = Partial<{
   [OrderSide.BUY]: number;
   [OrderSide.SELL]: number;
-};
+}>;
 
 type Premiums = Partial<{
   [SwapType.Submarine]: number;

diff --git a/lib/db/repositories/ReferralRepository.ts b/lib/db/repositories/ReferralRepository.ts
@@ -1,9 +1,5 @@
 import { QueryTypes } from 'sequelize';
-import {
-  OrderSide,
-  SuccessSwapUpdateEvents,
-  SwapType,
-} from '../../consts/Enums';
+import { SuccessSwapUpdateEvents, SwapType } from '../../consts/Enums';
 import Database from '../Database';
 import Referral, {
   DirectionalPremium,
@@ -140,25 +136,14 @@ class ReferralRepository {
           if (type === SwapType.Chain) {
             const directionalPremium = premium as DirectionalPremium;
 
-            if (
-              directionalPremium[OrderSide.BUY] === undefined ||
-              directionalPremium[OrderSide.SELL] === undefined
-            ) {
-              throw 'Chain swap premiums must specify both BUY and SELL values';
-            }
-
-            if (
-              [
-                directionalPremium[OrderSide.BUY],
-                directionalPremium[OrderSide.SELL],
-              ].some(
-                (p) =>
-                  p < ReferralRepository.minPremiumPercentage ||
-                  p > ReferralRepository.maxPremiumPercentage,
-              )
-            ) {
-              throw 'premium out of range';
-            }
+            Object.values(directionalPremium).forEach((p) => {
+              if (
+                p < ReferralRepository.minPremiumPercentage ||
+                p > ReferralRepository.maxPremiumPercentage
+              ) {
+                throw 'premium out of range';
+              }
+            });
           } else {
             if (typeof premium !== 'number') {
               throw 'premium must be a number';

diff --git a/test/integration/db/repositories/ReferralRepository.spec.ts b/test/integration/db/repositories/ReferralRepository.spec.ts
@@ -159,31 +159,27 @@ describe('ReferralRepository', () => {
               },
             },
           }),
-        ).rejects.toEqual(
-          'Chain swap premiums must specify both BUY and SELL values',
-        );
+        ).rejects.toEqual('premium must be a number');
       });
 
       test.each`
-        premiumValue
-        ${10}
-        ${{ [OrderSide.BUY]: 10 }}
-        ${{ [OrderSide.SELL]: 10 }}
+        premiumValue                                     | description
+        ${{ [OrderSide.BUY]: 10 }}                       | ${'only BUY'}
+        ${{ [OrderSide.SELL]: 10 }}                      | ${'only SELL'}
+        ${{ [OrderSide.BUY]: 10, [OrderSide.SELL]: 10 }} | ${'both BUY and SELL'}
       `(
-        'should throw if chain swap premium is invalid or incomplete ($premiumValue)',
+        'should accept valid partial chain swap premiums ($description)',
         async ({ premiumValue }) => {
-          await expect(
-            ReferralRepository.addReferral({
-              ...fixture,
-              config: {
-                premiums: {
-                  [SwapType.Chain]: premiumValue,
-                },
+          const ref = await ReferralRepository.addReferral({
+            ...fixture,
+            config: {
+              premiums: {
+                [SwapType.Chain]: premiumValue,
               },
-            }),
-          ).rejects.toEqual(
-            'Chain swap premiums must specify both BUY and SELL values',
-          );
+            },
+          });
+
+          expect(ref.config?.premiums?.[SwapType.Chain]).toEqual(premiumValue);
         },
       );