Modification du paramètre (bool) $in_footer => (array) $strategy pour wp_register_script
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestar300
changed the title
wp_register_script(bool) $in_footer=> (array) $strategy pour wp_register_script
firestar300
changed the title
(bool) $in_footer=> (array) $strategy pour wp_register_script(bool) $in_footer => (array) $strategy pour wp_register_script
n-langle
requested changes
Feb 4, 2025
n-langle
previously approved these changes
Feb 5, 2025
|
En modifiant ça, il faut supprimer la classe inc/Services/Assets_JS_Async.php et ce qui y est relié, puisque le coeur le fait tout seul. |
Rahe
requested changes
Feb 6, 2025
J'ai appliqué tes retours. |
Rahe
approved these changes
Feb 6, 2025
francoistibo
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afin de gérer les attributs
deferouasyncsur les balises<script>, j'ai modifié le comportement de la fonctionregister_scriptpour prendre en compte ce paramètre.Cf https://make.wordpress.org/core/2023/07/14/registering-scripts-with-async-and-defer-attributes-in-wordpress-6-3/