Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if implicit diagnostics file exist before writing the header #5750

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Mar 10, 2025

This is a small fix to prevent the implicit diagnostics file from being overwritten during a restart.

@dpgrote dpgrote added the component: implicit solvers Anything related to implicit solvers label Mar 10, 2025
@dpgrote dpgrote requested a review from JustinRayAngus March 10, 2025 20:20
Copy link
Contributor

@JustinRayAngus JustinRayAngus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dave,

Just need to do the same thing in Picard.H and then we can merge it.

Thanks!

@ax3l ax3l added bug Something isn't working component: diagnostics all types of outputs labels Mar 10, 2025
@dpgrote dpgrote changed the title Check is implicit diagnostics file exist before writing the header Check if implicit diagnostics file exist before writing the header Mar 10, 2025
@JustinRayAngus JustinRayAngus self-requested a review March 11, 2025 20:16
@JustinRayAngus JustinRayAngus enabled auto-merge (squash) March 11, 2025 20:16
@JustinRayAngus JustinRayAngus merged commit 8f6b9f1 into BLAST-WarpX:development Mar 11, 2025
37 checks passed
@dpgrote dpgrote deleted the fix_implicit_diagnostics_restart branch March 11, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: diagnostics all types of outputs component: implicit solvers Anything related to implicit solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants