added diagnostic_interval int for nonlinear solver diagnostic. #5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinRayAngus
added
the
component: implicit solvers
dpgrote
reviewed
Mar 10, 2025
| @@ -356,7 +357,8 @@ void NewtonSolver<Vec,Ops>::Solve ( Vec& a_U, | |||
| } | |||
| } | |||
|
|
|||
| if (!this->m_diagnostic_file.empty() && amrex::ParallelDescriptor::IOProcessor()) { | |||
| if (!this->m_diagnostic_file.empty() && amrex::ParallelDescriptor::IOProcessor() && | |||
| a_step%this->m_diagnostic_interval==0) { | |||
There was a problem hiding this comment.
You can make this change here to get the counting correct.
Suggested change
| a_step%this->m_diagnostic_interval==0) { | |
| (a_step + 1)%this->m_diagnostic_interval==0) { |
dpgrote
reviewed
Mar 10, 2025
| @@ -356,7 +357,8 @@ void NewtonSolver<Vec,Ops>::Solve ( Vec& a_U, | |||
| } | |||
| } | |||
|
|
|||
| if (!this->m_diagnostic_file.empty() && amrex::ParallelDescriptor::IOProcessor()) { | |||
| if (!this->m_diagnostic_file.empty() && amrex::ParallelDescriptor::IOProcessor() && | |||
| a_step%this->m_diagnostic_interval==0) { | |||
| std::ofstream diagnostic_file{this->m_diagnostic_file, std::ofstream::out | std::ofstream::app}; | |||
| diagnostic_file << std::setprecision(14); | |||
| diagnostic_file << a_step; | |||
There was a problem hiding this comment.
And here also
Suggested change
| diagnostic_file << a_step; | |
| diagnostic_file << a_step + 1; |
There was a problem hiding this comment.
And also below, increment the time diagnostic_file << a_time + a_dt;
JustinRayAngus
force-pushed
the
nonlinear_diagnostic
branch
2 times, most recently
from
d518331 to
894f8ab
Compare
…near solver is time at beginning of time step and the full time step.
…ther reduced diagnostics.
JustinRayAngus
force-pushed
the
nonlinear_diagnostic
branch
from
894f8ab to
aff2041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to parse in a step interval for the nonlinear diagnostic.