Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: restore input for test Langmuir_multi_nodal #5039

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Jul 10, 2024

While running a number of CI tests through run_test.sh, I noticed that the following warning message appears, regardless of which tests are being executed:

finding tests and checking parameters...
WARNING: required params for test Langmuir_multi_nodal not set
         buildDir = .
         inputFile = 
         dim = 3
WARNING: test Langmuir_multi_nodal will be skipped

I found that the inputFile parameter for the test Langmuir_multi_nodal had been removed from WarpX-tests.ini in #4914, resulting in this test being skipped since then.

However, the test itself was kept in WarpX-tests.ini and given the description of #4914, seemingly not related to CI, I suspect that the removal of its input file might have been unintentional.

Assuming that that's the case, I'm restoring the input file for the test Langmuir_multi_nodal, allowing its execution through run_test.sh.

If instead the intention was in fact to skip the test permanently, please let me know and I will remove the corresponding entry from WarpX-tests.ini, along with all related files (e.g., JSON benchmark).

@EZoni EZoni added the component: tests Tests and CI label Jul 10, 2024
@EZoni EZoni requested a review from ax3l July 10, 2024 00:43
@EZoni EZoni force-pushed the EZoni_restore_test branch from 8b76ba3 to e088e04 Compare July 10, 2024 18:13
@RemiLehe RemiLehe merged commit 892f65b into BLAST-WarpX:development Jul 11, 2024
45 checks passed
@EZoni EZoni deleted the EZoni_restore_test branch July 11, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants