Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test that checks absorption of particles in PML #4733

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Update test that checks absorption of particles in PML #4733

merged 4 commits into from
Feb 29, 2024

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Feb 28, 2024 •
edited
Loading

This removes duplication between different files.

@RemiLehe RemiLehe changed the title [WIP] Update test that checks absorption of particles in PML Update test that checks absorption of particles in PML Feb 28, 2024
@RemiLehe RemiLehe changed the title Update test that checks absorption of particles in PML [WIP] Update test that checks absorption of particles in PML Feb 28, 2024
RevathiJambunathan
RevathiJambunathan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@RevathiJambunathan RevathiJambunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RemiLehe for this PR. Looks good to me

@RevathiJambunathan RevathiJambunathan changed the title [WIP] Update test that checks absorption of particles in PML Update test that checks absorption of particles in PML Feb 29, 2024
@RemiLehe RemiLehe enabled auto-merge (squash) February 29, 2024 00:16
@RemiLehe RemiLehe merged commit 5f15bba into BLAST-WarpX:development Feb 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RevathiJambunathan RevathiJambunathan RevathiJambunathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiLehe @RevathiJambunathan